EngineHub / EngineHub/CraftBook

2 faults in ItemUtil.java (CraftBook)

Open
#867 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
320
Forks
166
Avg merge
6d 21h
Merged PRs (30d)
2

Description

CRAFTBOOK-3007 - Reported by AnorZaken

Was looking at the source and spotted 2 faults in
file: ItemUtil.java
method: public static boolean areItemsIdentical(ItemStack item, ItemStack item2)
faulty code begins at:
https://github.com/sk89q/craftbook/blob/a534703d6967ad5430e6cc114002b53364f826e2/src/main/java/com/sk89q/craftbook/util/ItemUtil.java#L323

Fault/error/scenario info can be found here:
http://forum.sk89q.com/threads/custom-recipes-wont-overwrite-vanilla-recipes.15374/#post-27308
(sorry, I posted there first)

Also included code that I believe will fix the two faults. (in the forum post)
(Not pull-ready, it's "similar" code from my own work related to craftbook - read the forum thread for more info.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.