EngineHub / EngineHub/CraftBook

Malformed Jukebox-logic allows to duplicate discs indefinitely

Open
#1,361 4 comments 0 reactions 0 assignees View on GitHub
status:pending type:bug
Dominant language
Java
Stars
320
Forks
166
Avg merge
6d 21h
Merged PRs (30d)
2

Description

### CraftBook Version

craftbook-3.10.13-SNAPSHOT

### Platform Version

Paper version 1.21.10-101-main@893ea74

### Confirmations

- [x] I am using the most recent Minecraft release.
- [x] I am using a version of WorldEdit compatible with my Minecraft version.
- [x] I am using a version of CraftBook compatible with my Minecraft version.
- [x] I am using the latest or recommended version of my platform software.
- [x] I am NOT using a hybrid server, e.g. a server that combines Bukkit and Forge. Examples include Arclight, Mohist, and Cardboard.
- [x] I am NOT using a fork of WorldEdit, such as FastAsyncWorldEdit (FAWE) or AsyncWorldEdit (AWE)

### Bug Description

Since the logic of Jukeboxes is malformed both while sucking and while putting, one can duplicate discs indefinitely. Here's a short preview outlining the situation:

https://streamable.com/po7ze6

This also works if the pipe simply had either no containers attached, or if all of these containers couldn't hold another of the disc in question.

### Expected Behavior

The disc should simply be transported to the other Jukebox.

### Reproduction Steps

1. Set up two empty Jukeboxes, one on a sticky- and one on a normal piston
2. Connect the pistons with glass-blocks
3. Add an input-clock (or clock manually)
4. Put a disc into the input - notice how it is dropped over and over again
5. Remove the disc manually - now the cycle stops

### Anything Else?

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.