EngineHub / EngineHub/CraftBook

Disc in Jukebox gets deletet with pipes

Open
#1,289 0 comments 0 reactions 0 assignees View on GitHub
status:pending type:bug
Dominant language
Java
Stars
320
Forks
166
Avg merge
6d 21h
Merged PRs (30d)
2

Description

**Versions**

CraftBook version: 3.10.5
Bukkit version: 1.18.1

**Describe the bug**
If you pipe in a music disc into a jukebox it only works if a disc is already in the jukebox. It also deletes the old disc when the new one is insertet.

**To Reproduce**
- create a simple pipe system
- put a jukebox to the end
- try to pipe a disk into the empty jukebox
- add disc to the jukebox
- activate the pipe again

**Expected behavior**
- it should be vise versa i think
- only pipe in the disc when the jukebox is empty so the disc gets not deleted

**Additional context**

https://github.com/EngineHub/CraftBook/blob/d8a3e9dad63b5a59eab48afa45e85a823083e2a6/src/main/java/com/sk89q/craftbook/mechanics/pipe/Pipes.java#L177

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.