EngineHub / EngineHub/CraftBook
Custom Crafting does not save NBT properly
- Dominant language
- Java
- Stars
- 320
- Forks
- 166
- Avg merge
- 6d 21h
- Merged PRs (30d)
- 2
Description
**Versions**
CraftBook version: 3.10.3;4680-f1ee2df AND 5.0.0;4696-73809ea
Bukkit version: PurPur-1022
**Describe the bug**
Item NBT data is not being saved properly when using custom crafting. It CAN store that information before the server restarts, however after restarting, it only saves name and lore. This prevents items from retaining custommodeldata, and custom NBT attributes on items.
**To Reproduce**
1. Create recipe with the resulting item having custom NBT flags
2. Restart the server
3. Attempt to craft that custom item and the data is gone.
**Expected behavior**
I would expect that this information would continue to be applicable for items - this makes Craftbook much more integral and compatible with other resources and custom items, so its a very important feature (at least, to me)
**Screenshots**

This is the item as it should be:

And this is the resulting item after restarting the server:

**Additional context**
The custom item in the example is using MMOItems - however all of that item data is attached to the item itself, which shouldn't cause issues like this. There was an issue with this before back in 2014 - however with ProtocolLib and many other updates and resources coming to fruition since that last report - I feel that this should really be revisited.
Contributor guide
Assessment
This issue has not been assessed yet.