EnergySystemsModellingLab / EnergySystemsModellingLab/MUSE2

Use custom `Serialize` implementations for metric types

Open
#1,159 1 comment 0 reactions 0 assignees View on GitHub
muse xiii
Dominant language
Rust
Stars
8
Forks
5
Avg merge
1d 2m
Merged PRs (30d)
37

Description

While we are using the `erased-serde` crate, which should allow us to do this, ~~we don't actually have custom `Serialize` implementations for `MetricTrait` types anyway~~ (edit: we do, but we're not using them); we use the `value()` method instead. We should fix this. In particular, this would be useful for `NPVMetric`, to make it clear to the user when we are using the fallback comparison because the denominator is zero.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.