EmbarkStudios / EmbarkStudios/puffin

Panic -> crash

Open
#199 8 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Rust
Stars
1.7k
Forks
111
Avg merge
2h 50m
Merged PRs (30d)
1

Description

**Describe the bug**
The more functions I profile the more often I get a panic from puffin.

**To Reproduce**
Unforutnatelly I do not have an reproducible example, I can share a game (15GB) and instructions...

**Expected behavior**
No panic.

**Device:**
- OS: Windows 11

**Additional context**
panic:
> .cargo\registry\src\index.crates.io-1cd66030c949c28d\puffin-0.19.0\src\frame_data.rs:455:18:
> We should have an unpacked frame if we don't have a packed one

I suspect it might be related to the threading model I use, but I would still expect it to not panic.
The game have two threading options:
- Do most things on main thread
- this panic only very rarely
- in this mode I call `new_frame` in **main** thread
- **and** majority of profiling events happen in **main** thread too
- `egui::profiler_ui` have its own thread, there is 32 threads, that have few profiling event
- Rendering and game logic separated
- the panic happens relatively often
- in this mode I call `new_frame` in **main** thread again
- **but** majority of profiling events happen in **other** threads
- `egui::profiler_ui` have its own thread, there is 30 threads, that have few profiling event

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.