EmbarkStudios / EmbarkStudios/puffin

Merging child scopes gives skewed timeline view

Open
#106 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
Rust
Stars
1.7k
Forks
111
Avg merge
2h 50m
Merged PRs (30d)
1

Description

When one uses the default "Merge children with same ID" it merges a child scopes regardless of the time offset they are on, which gives a skewed view over how the execution worked.

For example this:

![image](https://user-images.githubusercontent.com/1262692/197812215-371cd4d0-c5e5-4558-acc2-76064efe0bbf.png)

Becomes:

![image](https://user-images.githubusercontent.com/1262692/197812178-b533e987-4858-4fd8-8e57-6be8cbd399e1.png)

Which can be confusing an unexpected because on the latter (which is default) it looks like there is single large block that is missing smaller profiler scopes on it.

## Expected behavior

I did expect it to only merge child scopes that were next to each other on the time line, maybe not exactly (due to timing precision) but not fundamentally change the timing view.

Let's discuss how to proceed with this or if we simply should disable "Merge children with same ID" by default and describe this gotcha, as believe we've internally run into this quite a few times causing confusion as the profiler with it is not showing the correct time perspective on things

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.