Elytrium / Elytrium/LimboAPI

[NOT A BUG] PostLoginEvent and LoginEvent not firing without LimboPlayer#disconnect call

Open
#51 1 comment 0 reactions 0 assignees View on GitHub
documentation
Dominant language
Java
Stars
310
Forks
121
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
When I add a callback to LoginLimboRegisterEvent, the LoginEvent and PostLoginEvent stop firing completely for all plugins.

**To Reproduce**
Steps to reproduce the behavior:
1. Add a listener for LoginEvent and PostLoginEvent and put a breakpoint/print statement to it
2. Add a listener for LoginLimboRegisterEvent and add a callback in it
3. Try to connect
4. Observe, that our LoginEvent and PostLoginEvent did not fire

**Expected behavior**
LoginEvent and PostLoginEvent should fire normally.

**Screenshots**
*Not applicable*

**Server Info (please complete the following information):**
- All Limbo plugins versions:
- [LimboAPI 1.0.4-SNAPSHOT](https://github.com/Elytrium/LimboAPI/releases/tag/dev-build-jdk-17)

- [/velocity dump link](https://bin.kyngs.xyz/neferupinu.json)

**Additional context**
I suspect that this is because LimboAPI takes control over the login process when you add a callback, but forgets to fire applicable events which would be fired under a normal scenario.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.