ElementsProject / ElementsProject/lightning

deleted_forward_fees integer type in vars table too small

Open
#9,467 0 comments 0 reactions 1 assignee Claimed by @Andezion View on GitHub
Dominant language
C
Stars
3.1k
Forks
1k
Avg merge
4d 10h
Merged PRs (30d)
13

Description

deleted_forward_fees in the vars table is using the intval column which is only 32bit integer from -2147483648 to +2147483647.

since the fees are stored in msats that's only a little more than 2 million sats. that is not enough for a long running node which then overflows this value and becomes negative.

ask me how I know.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.