ElementsProject / ElementsProject/lightning

can't have two offers with the same description

Open
#7,711 8 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
3.1k
Forks
1k
Avg merge
3d 13h
Merged PRs (30d)
23

Description

With

`lightning-cli offer -k "amount"="any" "description"="test10" "label"="testing offers"`

and

`lightning-cli offer -k "amount"="any" "description"="test10" "label"="testing offers2"`

we can't have two offers with the same description. Changing the label results in the original offer being returned instead of creating a new offer with the new label. Is the `offer_metadata` field of offers even used?

Why have a label feature if it can't be used?

In light of https://github.com/ElementsProject/lightning/issues/7710, this is problematic. Also, with https://github.com/ElementsProject/lightning/issues/7709, I don't know how to re-create an offer if the first one had no blinded paths and I want an offer with a specific description and blinded paths.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.