ElementsProject / ElementsProject/lightning

Peer storage doesn't scale

Open
#6,652 3 comments 1 reaction 1 assignee Assigned to @adi2011 View on GitHub
discussion protocol
Dominant language
C
Stars
3.1k
Forks
1k
Avg merge
4d 10h
Merged PRs (30d)
13

Description

If SCBs get larger than 64KB, the `peer_storage` message sent to peers gets truncated. This means that later when the SCB is sent back in the `your_peer_storage` message, it fails the MAC check.

Based on typical `scb_chan` serialized sizes, peer storage starts to break at ~500 channels. At maximum `scb_chan` serialized sizes, things break at ~200 channels.

One potential solution is to packetize large SCBs for transfer to/from peers.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.