ElementsProject / ElementsProject/libwally-core

Provide a method to peek at a serialized transaction to determine whether it's an elements transaction or not

Open
#140 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
307
Forks
159
Avg merge
2h 56m
Merged PRs (30d)
4

Description

The code internally already has methods that detect serialization formats, but it is not exposed anywhere. It'd be nice to be able to peek at a serialized transaction and determine its serialization type.

Currently the only alternative is to know ahead of time, or first try one method, and if that fails try the other, which is a bit cumbersome.

For an example of this see this [commit](https://github.com/ElementsProject/lightning/pull/3078/commits/3fe4b9e6237e1f45b15115b069798dee0507b4c8): we have to pass in `is_elements` in the wire message before parsing the transaction included in the same message so we can set that global variable and parse correctly.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.