ElementsProject / ElementsProject/elements

Intermittent stall in unit tests

Open
#931 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.2k
Forks
416
Avg merge
1d 23h
Merged PRs (30d)
15

Description

There is a race condition where we wind up enabling dynafed globally when running all the unit tests. Then in the `TestChain100Setup` (used by most of the wallet tests, for example), try to PoW up a bunch of blocks, in the line
https://github.com/ElementsProject/elements/blob/88067ddbe4223e43a4c86912928b28b834bbf69e/src/test/test_bitcoin.cpp#L168
which will just run forever. In dynafed `nNonce` doesn't go into the hash.

We should either force dynafed off for these tests, or just replace the PoW loop with a signed-block setup.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.