ElementsProject / ElementsProject/elements

RPCs that need to use the wallet should check if it's unlocked

Open
#881 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.2k
Forks
416
Avg merge
1d 23h
Merged PRs (30d)
15

Description

At some appropriate place in `issueasset` in `rpcwallet.cpp` (after `LOCK(pwallet->cs_wallet)` but before doing anything that uses the wallet), there should be a call to `EnsureWalletIsUnlocked(pwallet)`. Otherwise we crash when trying to sign if the wallet has a password and is not unlocked.

We should also check whether any other RPCs have this issue (any RPCs that need to use the wallet for signing, which I think is the only thing you need it unlocked for?)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.