ElementsProject / ElementsProject/elements

Liquid INV rate probably too low

Open
#1,243 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
1.2k
Forks
416
Avg merge
1d 23h
Merged PRs (30d)
15

Description

https://github.com/ElementsProject/elements/blob/cfc10a5dd6c18db140dd1d1e94dfa8cad16bfe36/src/net_processing.cpp#LL136C1-L136C1

```c++
/** Maximum rate of inventory items to send per second.
* Limits the impact of low-fee transaction floods. */
static constexpr unsigned int INVENTORY_BROADCAST_PER_SECOND = 7;
```

Given liquid's higher block rate, this value should probably be higher ([also probably true on Bitcoin itself](https://github.com/bitcoin/bitcoin/pull/27630)) -- perhaps it should be coded as `(4200 / consensusParams.nPowTargetSpacing)` ?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.