ElemeFE / ElemeFE/element-react

Autocomplete performance degrade on frequent value update

Open
#911 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.8k
Forks
435
PR merge metrics
No merged PRs in 30d

Description

### Description

The webpage will become very unresponsive after autocomplete value is updated a few time

### Reproduce Steps

1. type something on auto complete
2. delete it
3. type something on auto complete
4. delete it
5. type something on auto complete
6. keep doing until your browser freeze

### Error Trace (if possible)

```
[Violation] 'requestAnimationFrame' handler took 104ms resize-event.js:79
[Violation] 'requestAnimationFrame' handler took 186ms
[Violation] 'requestAnimationFrame' handler took 402ms
[Violation] 'requestAnimationFrame' handler took 764ms
[Violation] 'requestAnimationFrame' handler took 1555ms
```

### Solution

I think it is due to heavy rerendering process
we may want to have something like this at the Suggestion:
```
shouldComponentUpdate(nextProps, nextState) {
return (this.state.showPopper !== nextState.showPopper || this.state.dropdownWidth !== nextState.dropdownWidth)
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.