ElemeFE / ElemeFE/element-react

是否能将 flow 的定义和相关的包升级到最新版本?

Open
#803 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.8k
Forks
435
PR merge metrics
No merged PRs in 30d

Description

### Description

在尝试修复一些组件问题时,无法通过 flow 的检查,比如`createPortal`方法在老版本里面直接没有。个人对 flow 实在不熟悉,尝试升级版本后大量的检查错误无法解决。如果维护者能够解决相关的语法和约束问题,其他开发者可以帮助修复一些组件问题。

### Reproduce Steps

1. 升级`@types/react`和`flow-bin`到最新版;
2. `npm test`

### Error Trace (if possible)

大量下面类似的错误:

~~~
Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ src/auto-complete/AutoComplete.jsx:193:19

Cannot get React.Element because property Element is missing in object type [1].

src/auto-complete/AutoComplete.jsx
190│ }
191│ }
192│
193│ render(): React.Element {
194│ const { disabled, placeholder, name, size, icon, append, prepend, onIconClick, popperClass } = this.props;
195│ const { inputValue, suggestions } = this.state;
196│

/private/tmp/flow/flowlib_34436567/react.js
[1] 258│ declare export default {|
259│ +DOM: typeof DOM,
260│ +PropTypes: typeof PropTypes,
261│ +version: typeof version,
262│ +checkPropTypes: typeof checkPropTypes,
263│ +createClass: typeof createClass,
264│ +createContext: typeof createContext,
265│ +createElement: typeof createElement,
266│ +cloneElement: typeof cloneElement,
267│ +createFactory: typeof createFactory,
268│ +createRef: typeof createRef,
269│ +isValidElement: typeof isValidElement,
270│ +Component: typeof Component,
271│ +PureComponent: typeof PureComponent,
272│ +Fragment: typeof Fragment,
273│ +Children: typeof Children,
274│ |};

Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ src/auto-complete/AutoComplete.jsx:229:16

Cannot call ClickOutside because a callable signature is missing in module react-click-outside [1].

src/auto-complete/AutoComplete.jsx
226│ component: PropTypes.any
227│ };
228│
229│ export default ClickOutside(AutoComplete);
230│

flow/modules.js
[1] 7│ declare module 'react-click-outside' {
8│ declare var exports: {
9│ (module: any): any
10│ }
11│ }
~~~

### Solution

需要熟悉 flow 的开发者来解决定义问题。

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.