Election-Tech-Initiative / Election-Tech-Initiative/electionguard-python

🗑 Remove delimiters in hashes

Open
#536 4 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
168
Forks
103
PR merge metrics
No merged PRs in 30d

Description

## Feature Request

**Description**
@benaloh proposed to not use any delimiters between parameters of hashes. The idea would be simplify the hash itself. It also removes confusion on whether any delimiters are used between parameters of hashes.

Another option would be to be more clear of exactly what the delimiters are and how they are used in documentation.

**Proposed Solution**

This would involve removing the delimiters shown in these lines:
https://github.com/microsoft/electionguard-python/blob/e35b68dc3175243ffaf872e9a0ea56c5b8a05830/src/electionguard/hash.py#L73

https://github.com/microsoft/electionguard-python/blob/e35b68dc3175243ffaf872e9a0ea56c5b8a05830/src/electionguard/hash.py#L100

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.