Election-Tech-Initiative / Election-Tech-Initiative/electionguard-python

🐞 Factories should be using ElectionGuard Sample Data

Open
#518 0 comments 0 reactions 0 assignees View on GitHub
bug good first issue help wanted
Dominant language
Python
Stars
168
Forks
103
PR merge metrics
No merged PRs in 30d

Description

### Current Behavior

Both factories and subsequently the sample data generation should be relying on the **sample_data.zip** from the root `electionguard` repository.

### Expected Behavior

The `data` folder could be empty until after the data is pulled using `make environment`.

This is the data folder to be deleted:
https://github.com/microsoft/electionguard-python/tree/main/data

This involves updating `ElectionFactory`, `BallotFactory` and some of `SampleGenerator`
https://github.com/microsoft/electionguard-python/blob/e35b68dc3175243ffaf872e9a0ea56c5b8a05830/src/electionguard_tools/factories/ballot_factory.py#L32

https://github.com/microsoft/electionguard-python/blob/e35b68dc3175243ffaf872e9a0ea56c5b8a05830/src/electionguard_tools/factories/election_factory.py#L54

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.