Election-Tech-Initiative / Election-Tech-Initiative/electionguard-core2

✨ Update data for R cofactor constant

Open
#391 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C#
Stars
14
Forks
12
PR merge metrics
No merged PRs in 30d

Description

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Suggestion

The R cofactor array data needs to be updated. This is causing failures.

test_group.cpp:
```
// TODO: this test is failing. Enable when we have a data solution to R_ARRAY, or R_ARRAY_REVERSE.
// TEST_CASE("Test R is converted correctly")
// {
// // Arrange
// auto convert_bytes = bytes_to_hex(R().toBytes());
// auto expected = bignum_to_hex_string(const_cast(R_ARRAY), MAX_P_LEN);

// // Act
// auto result = ElementModP::fromHex(expected);

// // Assert
// CHECK(convert_bytes == result->toHex());
// }
```

### Possible Implementation

_No response_

### Anything else?

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.