Election-Tech-Initiative / Election-Tech-Initiative/electionguard-core2
✨ HACL use precompiled export header
Open
enhancement
- Dominant language
- C#
- Stars
- 14
- Forks
- 12
- PR merge metrics
- No merged PRs in 30d
Description
### Is there an existing issue for this?
- [ ] I have searched the existing issues
### Suggestion
Currently HACL CPP wrapper exports all symbols like this for windows:
```cmake
if(MSVC)
message("++ Exporting all Symbols")
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS TRUE)
endif()
```
we should instead use the GenerateExportHeader functions provided by cmake
https://cmake.org/cmake/help/latest/module/GenerateExportHeader.html
additionally, we should expand the export symbols to gnu/clang as well
### Possible Implementation
_No response_
### Anything else?
_No response_
Contributor guide
Assessment
This issue has not been assessed yet.