ElMassimo / ElMassimo/iles

Vue client app should be created with `createSSRApp` for efficient client hydration

Open
#149 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
1.2k
Forks
36
PR merge metrics
No merged PRs in 30d

Description

[troubleshooting section]: https://iles-docs.netlify.app/faqs/troubleshooting

- [x] I have read the __[troubleshooting section]__ before opening an issue.
- [x] I have tried upgrading `iles` and `vite`.

### Description 📖

In multiple locations `createApp` is used instead of `createSSRApp` (e.g., https://github.com/ElMassimo/iles/blob/af74635967d7136ce46ef16c83b3ea453a141e17/packages/hydration/vue.ts#L6). I think this prevents efficient client-side hydration.

When re-hydrating server-side rendered HTML, `createSSRApp` should also be used on the client to enable efficient re-hydration. See: https://vuejs.org/guide/scaling-up/ssr.html#client-hydration

### Reproduction 🐞

This can be reproduced with every Vue powered iles app.

### Logs 📜

Not applicable.

### Screenshots 📷

Not applicable.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.