EgorBo / EgorBo/Disasmo

Disasmo overrides project's `DefineConstants`

Open
#52 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
C#
Stars
707
Forks
45
PR merge metrics
No merged PRs in 30d

Description

Since the `dotnet build` cmdline now includes `/p:DefineConstants=DISASMO`, this value is taken instead of any value defined in the csproj.

I like being able to detect Disasmo runs from my project and/or code, but maybe an alternate property would be better. We could then bridge that into `DefineConstants` ourselves if we want that.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating where the dotnet build command adds /p:DefineConstants=DISASMO, then reproduce it with a project that already defines constants in its csproj. Done means project-defined constants are preserved while Disasmo runs remain detectable; the issue leaves the preferred alternate property undecided.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
build-system, devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.