TelemetryService should insert into database using device name instead of SKU
- Dominant language
- Go
- Stars
- 1.4k
- Forks
- 137
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 18
Description
**Is your feature request related to a problem? Please describe.**
Currently when we enable telemetryService for a device with SQL, the name of the entry will be the SKU of the device in `edgeDevice`. This makes it harder to manage when we have to identical devices with the same SKU
**Describe the solution you'd like**
The solution would be to use device name for now. Since they are unique for a Kubernetes cluster. For now let's keep it within a single cluster. We can add in cluster id in the future
**Describe alternatives you've considered**
Using a slightly different SKU number for different devices
**Additional context**
Should be fixed here https://github.com/Edgenesis/shifu/blob/main/pkg/deviceshifu/deviceshifubase/pushtelemetry.go#L26
Contributor guide
Research direction
Start at pkg/deviceshifu/deviceshifubase/pushtelemetry.go around line 26 and inspect how the telemetry entry for edgeDevice is inserted into SQL. Change the entry name to use the device name rather than its SKU, keeping uniqueness scoped to a Kubernetes cluster; done means identical SKUs can produce distinct device entries.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes, sql
- Domain
- backend, database
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100