EddyVerbruggen / EddyVerbruggen/nativescript-nodeify

Hook fails if nativescript-nodeify is a devDependency

Open
#43 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
93
Forks
27
PR merge metrics
No merged PRs in 30d

Description

To reproduce:
* `rm -rf platforms/android`
* `tns platform add android`
* `tns build android`

Here is the output from my terminal. Specifically note the error message at the end:
```
Preparing project...
Project successfully prepared (android)
Executing after-prepare hook from /path/to/project/hooks/after-prepare/nativescript-dev-babel.js
Processing complete
Executing after-prepare hook from /path/to/project/hooks/after-prepare/nativescript-nodeify.js
Cannot find module '/path/to/project/platforms/android/app/src/main/assets/app/tns_modules/nativescript-nodeify/patch-npm-packages.js'
```
I believe this is related to #31. Moving the `nativescript-nodeify` line to `dependencies` instead of `devDependencies` solves the problem.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.