EasyCorp / EasyCorp/EasyAdminBundle
Translations with undefined domain?
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 4.3k
- Forks
- 1.1k
- Avg merge
- 8d 2h
- Merged PRs (30d)
- 11
Description
Describe the bug
I was just wondering about some translations that seem to have an undefined domain:
Up until now it was only "download" that was added (to the file _undefined+intl-icu.en.xlf when extracting translations).
Today the following keys were added to the file (after updating to v5.2.0):
- paginator.label
- paginator.first
- paginator.more_pages
- paginator.last
- paginator.results
- paginator.previous
- paginator.next
To Reproduce
Install easyadmin-bundle and extract translations (e.g. php bin\console tran:ex --force en).
(OPTIONAL) Additional context
Not really a bug as the translations work with the "undefined"-domain, I was just curious if this was intentional or if the mentioned translations should go into EasyAdminBundle.en.xlf (especially as the new keys "paginator.label" and "paginator.more_pages" are also added to that file as duplicates).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with php bin\console tran:ex --force en, then compare undefined+intl-icu.en.xlf with EasyAdminBundle.en.xlf. Trace where the paginator keys and download key acquire their translation domain. Done when the behavior is explained and the translations are consistently assigned to the intended domain without unintended duplicates.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, symfony
- Domain
- internationalization, localization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100