EasyCorp / EasyCorp/EasyAdminBundle
setFilters / addFilters on AdminUrlGenerator
Open
Nobody has claimed this yet.
feature
priority: important
- Dominant language
- PHP
- Stars
- 4.3k
- Forks
- 1.1k
- Avg merge
- 8d 2h
- Merged PRs (30d)
- 11
Description
Setting filter values when building a url with the admin generator is clunky
->set('filters', ['seller' => ['value' => $entity->getId(), 'comparison' => '=']])
A function specifically designed to help set the value and operator would be nice, e.g.:
->setFilter('seller', $entity->getId(), '=')
Maybe addFilter would be a better name as multiple filters can be set
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at AdminUrlGenerator and trace how set('filters', ...) is converted into the URL. Decide whether setFilter or addFilter fits the existing API, then add coverage for setting a filter value and comparison operator; done means callers can express the shown use case without manually building the filters array.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, symfony
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100