EarendelDevelopers / EarendelDevelopers/factorio-mods

AAI Programmable Vehicles, error using Aircraft mod with Aircraft Realism present

Open
#391 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
17
Forks
4
PR merge metrics
No merged PRs in 30d

Description

**Description**
Aircraft Realism is used to add takeoff to aircrafts from the Aircraft mod. This is accomplished by creating two planes, one with collision (grounded) and one without (airborne).

AAI Programmable Vehicles modifies the aircraft from the Aircraft mod to have no guns, but does not modify the airborne version. This causes a error when Aircraft Realism notices the grounded and airborne planes have different numbers of guns.

```
The mod Aircraft Realism (2.0.3) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event AircraftRealism::on_tick (ID 0)
__AircraftRealism__/logic/planeController.lua:61: Old plane and new plane inventories are different sizes. Check plane prototypes
stack traceback:
[C]: in function 'assert'
__AircraftRealism__/logic/planeController.lua:61: in function 'copyInventory'
__AircraftRealism__/logic/planeController.lua:230: in function 'transitionPlane'
__AircraftRealism__/logic/planeController.lua:470: in function 'checkTransitionTakeoff'
__AircraftRealism__/logic/planeController.lua:482: in function 'updateGroundedPlane'
__AircraftRealism__/logic/planeController.lua:547: in function 'handler'
__AircraftRealism__/control.lua:48: in function <__AircraftRealism__/control.lua:40>
```

I have been getting bug reports about this, but is not something the Aircraft Realism mod can fix.

* https://mods.factorio.com/mod/AircraftRealism/discussion/69519ebb1822207f94bd3737
* https://mods.factorio.com/mod/AircraftRealism/discussion/698d5778fab043ef81fe6a63
* https://mods.factorio.com/mod/AircraftRealism/discussion/69374b83b0cef891e107ca62
* https://mods.factorio.com/mod/AircraftRealism/discussion/67d153de3f19f8c652803307

**To Reproduce**
1. Start a new save with Aircraft, Aircraft Realism, AAI programmable vehicles
2. Get in a Cargo plane and try to take off

**Possible Fix**
For cargo plane, add the following 3 lines in `prototypes/ai-vehicles.lua`. Similar procedure applies for other planes.

```
-- aircraft mod
if data.raw.car["cargo-plane"] then
-- hauler types should not have guns
data.raw.car["cargo-plane"].guns = nil
end
+if data.raw.car["cargo-plane-flying"] then
+ data.raw.car["cargo-plane-flying"].guns = nil
+end
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.