EVerest / EVerest/cbexigen

ISO15118-20 AC message set introduces new response code type

Open
#134 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
69
Forks
36
Avg merge
3h 30m
Merged PRs (30d)
1

Description

### Describe the bug

iso20_AC_Datatypes.h introduces iso20_ac_responseCodeType for response codes. This is an identical list to iso20_CommonMessages_Datatypes.h iso20_responseCodeType. The AC (and AC DER) message sets should use iso20_responseCodeType as defined by the schema.

In practice this means casting between the enum types, seems unnecessary if AC message set imported the existing types.

The diagram in Annex A shows the AC message set should derive from types in Common Types.

### To Reproduce

-

### Anything else?

-

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by comparing iso20_AC_Datatypes.h with iso20_CommonMessages_Datatypes.h and trace the generator or schema inputs that produce the duplicated response-code type. Regenerate or run the relevant project checks, and confirm that AC and AC DER use iso20_responseCodeType without the unnecessary enum casts.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.