EVerest / EVerest/cbexigen

Why does V2GTP20_ReadHeader expect me to know the payload ID?

Open
#111 4 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
69
Forks
36
Avg merge
3h 30m
Merged PRs (30d)
1

Description

Hi there,

I have a quick question behind the intention of

`int V2GTP20_ReadHeader(const uint8_t* stream_data, uint32_t* stream_payload_length, uint16_t v2gtp20_payload_id);`

Why does this signature expect the caller to know the payload id? When receiving data, you have no clue what type of payload you will receive. Probing until `V2GTP20_ReadHeader` returns without error seems a little cumbersome, doesn't it?

Cheers,
Richard

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.