ESMCI / ESMCI/cime

Refactor config_archive.xml/case_st_archive.py

Open
#4,792 3 comments 0 reactions 1 assignee Claimed by @jasonb5 View on GitHub
Low Priority
Dominant language
Python
Stars
174
Forks
225
Avg merge
1d 16h
Merged PRs (30d)
14

Description

The regex patterns for matching history/restart files for archiving are partial hard-coded. Updates require PRs like #4788 to be made when the naming changes. We should update these patterns to be fully definable in `config_archive.xml`.

- https://github.com/ESMCI/cime/blob/2343dba8a347a57a41f7bf9e650ae98104209554/CIME/XML/archive_base.py#L142
- https://github.com/ESMCI/cime/blob/2343dba8a347a57a41f7bf9e650ae98104209554/CIME/XML/archive_base.py#L253

This would also be a good opportunity to refactor `case_st_archive.py`, some of this code belongs in `CIME/XML/archive_base.py` and `CIME/XML/archive.py`. There's also a bit of component specific code that should be moved out into `config_archive.xml`.

- https://github.com/ESMCI/cime/blob/c63fd0b46486ec6d85d7138e92c54b58d9149a14/CIME/case/case_st_archive.py#L320-L326
- https://github.com/ESMCI/cime/blob/c63fd0b46486ec6d85d7138e92c54b58d9149a14/CIME/case/case_st_archive.py#L576-L591
- https://github.com/ESMCI/cime/blob/c63fd0b46486ec6d85d7138e92c54b58d9149a14/CIME/case/case_st_archive.py#L686-L697

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.