ESMCI / ESMCI/cime

Different argument order for library vs. component buildlibs

Open
#4,034 3 comments 0 reactions 1 assignee Assigned to @jgfouca View on GitHub
Low Priority tp: CIMElib ty: enhancement
Dominant language
Python
Stars
174
Forks
225
Avg merge
3d 10h
Merged PRs (30d)
18

Description

This isn't exactly a bug itself, but can contribute to bugs, including one that stumped @jedwards4b and me for a while this week: The order of the command-line arguments to the buildlib script, when called as a subprocess, differs for libraries

https://github.com/ESMCI/cime/blob/4312d850621c6107b3fd14e84857519c9b906e34/scripts/lib/CIME/build.py#L462-L463

vs components

https://github.com/ESMCI/cime/blob/4312d850621c6107b3fd14e84857519c9b906e34/scripts/lib/CIME/build.py#L514-L515

One implication of this is that the `parse_input` command in `buildlib.py` cannot be used for libraries.

Changing the argument order for components would be a pain (requiring coordinated changes in a bunch of repositories). But I wonder if it would be feasible to change the argument order for libraries to match that of components?

Even better would be changing these positional arguments to named arguments – for both libraries and components – but I can't think of a backwards compatible way to do that (so again, it would require coordinated updates in a bunch of repositories).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.