ESCOMP / ESCOMP/atmospheric_physics

ndrop_bam cleanup (answer-changing): pres calculation

Open
#421 0 comments 0 reactions 0 assignees View on GitHub
aerosols cleanup end_of_conversion
Dominant language
Fortran
Stars
12
Forks
38
Avg merge
11h 16m
Merged PRs (30d)
5

Description

During the review of https://github.com/ESCOMP/atmospheric_physics/pull/411, @nusbaume originally wrote:

> I wouldn't do anything about this now (as it would change answers), but it makes me a little nervous that this is calculating its own pressure instead of just using the provided pressure (e.g. air_pressure).
>
> At some point it might be good to double-check the paper and these equations to make sure everything is consistent with the rest of the physics (e.g. it's not using dry air pressure when expecting total air pressure), but for now maybe just add it to the "future work" issue?

The relevant code is ` pres = rair*rhoair*tair`

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the ndrop_bam implementation and the review discussion in PR 411, focusing on `pres = rair*rhoair*tair`. Done means reconciling that calculation with the cited paper and the project's provided-pressure conventions, then agreeing on a change that avoids unintended answer differences.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
hpc
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.