ESCOMP / ESCOMP/atmospheric_physics

Change coords1d ddt metadata units to Pa

Open
#391 0 comments 0 reactions 0 assignees View on GitHub
cleanup
Dominant language
Fortran
Stars
12
Forks
38
Avg merge
11h 16m
Merged PRs (30d)
5

Description

During review of #370, @peverwhee wrote:
> Is Pa correct? The metadata says that this has units = none

about
```
type(coords1d), intent(in) :: p ! Pressure coordinates for solver [Pa]
```

@jimmielin wrote:
> It's a ddt with the underlying units as `Pa`. I wasn't sure why I noted `units = none` in the metadata (it's what was done for HB), maybe I set the ddt units as `none` out of habit, but the comment is more correct.

I think if it works to annotate `units = Pa` for the ddt it should be that way.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.