ESCOMP / ESCOMP/atmospheric_physics

Geopotential height should be updated after dme_adjust

Open
#238 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Fortran
Stars
12
Forks
38
Avg merge
11h 16m
Merged PRs (30d)
5

Description

Currently the `dme_adjust` scheme updates the pressure and water species fields, both of which modify the geopotential heights. In CAM this is a non-issue because `dme_adjust` is always called at the end of physics. However, there is no way to really guarantee that in CAM-SIMA, and so a safer option would be to just simply call the `geopotential_temp` scheme after `dme_adjust` in any relevant suite files.

Note that currently `dme_adjust` is not actually needed for the two dycores currently enabled in CAM-SIMA (SE and MPAS), so this is a low-priority issue. However, if we ever bring on a moist pressure-based dycore (e.g. FV3 or the SE-NH dycore) then this will likely need to be resolved to ensure that there are no physical inconsistencies in the model state if a user or developer modifies the suite file.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.