ESCOMP / ESCOMP/atmospheric_physics

CCPP-ize get_hydrostatic_energy and remove cam_thermo_formula dependency from check_energy_chng

Open
#157 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Fortran
Stars
12
Forks
38
Avg merge
11h 16m
Merged PRs (30d)
5

Description

As brought up during the review of https://github.com/ESCOMP/atmospheric_physics/pull/145 (check_energy CCPP-ization), the dependency on `cam_thermo_formula` in `check_energy_chng` run and timestep initialize:

> I'm not sure how portable the formulas for different dycores are for models beyond CAM, and this doesn't seem to be as easy to work around as the dycore_energy_consistency_adjust_run situation where a different flag could be used. I would suggest perhaps we could leave it as-is so we could CCPP-ize get_hydrostatic_energy and the corresponding formula flags in the future?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.