ESCOMP / ESCOMP/SimpleLand

Convert LH to evap (kg) AFTER doing SH correction

Open
#8 3 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
Fortran
Stars
15
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Right now I'm converting latent heat flux to water units *before* doing the "did you try to evaporate more water than you have" check (which puts excess latent heat flux into sensible heat flux). It should happen after, otherwise the `evap` variable (in water units) won't match the `lhflx` variable (in energy units) if some of lhflx gets transferred to shflx. Quick fix, but if I try to do it right now when I'm tired I'll break something. I then use `evap` to subtract water from the bucket, which wouldn't have the adjustment for sensible heat flux included - maybe this is causing some of the soil moisture followed by nan problems. Maybe not. Regardless, it seems wrong, so should be fixed!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.