ESCOMP / ESCOMP/POP2-CESM

Bad XML entry in config_components.xml

Open
#15 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Fortran
Stars
8
Forks
27
PR merge metrics
No merged PRs in 30d

Description

### Description of the issue:

The following block of code in `cime_config/config_components.xml` doesn't behave as expected:

```

char
full,partial
full

full
partial

build_pop
env_build.xml
Determine surface freshwater and heat forcing settings.
The full option yields settings that are appropriate for coupling to an
active atmospheric model (e.g., a B-type compset). The partial option yields
settings that are appropriate for coupling to a data atmospheric model
(e.g., a C or G-type compset). The create_newcase command selects the
appropriate setting for this variable based on the specified compset.
Users should NOT EDIT this setting.

```

The default behavior of CIME is to take the last `value` option that matches the maximum number of attributes, so a compset with `DATM%CPLHIST.*_POP2` in the long name will end up using `OCN_COUPLING=partial` rather than `full`. To fix this, either start the `values` block with `` OR swap the order of the `` items (doing both will continue to provide the wrong value for `CPLHIST` compsets!). I think swapping the `` items is the better solution as we don't use the `match` attribute anywhere else in `cime_config/`.

### Version:
- CESM: 2.X (2.0, 2.1, and the 2.2 development branches)
- POP2: `cesm2_0_x_rel`, `cesm2_1_x_rel`, and `master`

### Machine/Environment Description:

Discovered on cheyenne during a code review with @klindsay28 but problem should be evident on any machine

### Any xml/namelist changes or SourceMods:

No

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.