ESCOMP / ESCOMP/CTSM

Duplicate definitions of SMP (smp_l)

Open
#447 1 comment 0 reactions 0 assignees View on GitHub
bug priority: low science
Dominant language
Fortran
Stars
352
Forks
361
Avg merge
2d 21h
Merged PRs (30d)
7

Description

### General bug information

**CTSM version you are using:** release-clm5.0.01

**Does this bug cause significantly incorrect results in the model's science?** Yes

**Configurations affected:** All

### Details of bug

There are two different definitions for SMP (smp_l in the code). The first, and correct (consistent), is in SoilWaterMovementMod.F90 (subroutine compute_hydraulic_properties) where smp_l(c,j) = smp(j). The second, which should be removed because it is overwriting the first definition and is inconsistent with how smp is used in the soil water equations, is in HydrologyNoDrainageMod.F90:

do j = 1, nlevgrnd
do fc = 1, num_hydrologyc
c = filter_hydrologyc(fc)

s_node = max(h2osoi_vol(c,j)/watsat(c,j), 0.01_r8)
s_node = min(1.0_r8, s_node)

smp_l(c,j) = -sucsat(c,j)*s_node**(-bsw(c,j))
smp_l(c,j) = max(smpmin(c), smp_l(c,j))
end do
end do

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.