ESCOMP / ESCOMP/CTSM

Only allow one of use_fates_inventory_init or use_fates_dbh_init to be TRUE and either only under a cold-start

Open
#4,022 2 comments 0 reactions 0 assignees View on GitHub
enhancement FATES usability
Dominant language
Fortran
Stars
352
Forks
361
Avg merge
6d 6h
Merged PRs (30d)
8

Description

### Brief summary of bug

There are three initialization options under a FATES cold-start:
- inventory
- DBH
- nearly bare ground

Neither inventory or DBH should be allowed if it isn't a coldstart
And inventory AND DBH shouldn't both be allowed to be on

### General bug information

**CTSM version you are using:** ctsm5.4.039

**Does this bug cause significantly incorrect results in the model's science?** No
**Configurations affected:** FATES cold-start
### Details of bug

I tried this in a testcase:

ERS_D_Ld10.f45_f45_mg37.I2000Clm50FatesCruRsGs.derecho_intel.clm-FatesColdNoCompInitDbh

where I changed:

CLM_FORCE_COLDSTART==off

And added settings for

finidat
fates_inventory_init (and fates_inventory_ctrl_filename)

and found there wasn't an error that came up for this. There should be two errors to prevent this:
- choosing either one with a finidat file set
- turning both on at once

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.