FATES `successful_ignitions` spitfire mode does not pass lightning data
- Dominant language
- Fortran
- Stars
- 352
- Forks
- 361
- Avg merge
- 6d 6h
- Merged PRs (30d)
- 8
Description
### Brief summary of bug
The FATES `successful_ignitions` option should pass lightning data to FATES, but it currently sets `fates_fire_no_data_type` as the fire method.
### General bug information
**CTSM version you are using:** ctsm5.4.038
**Does this bug cause significantly incorrect results in the model's science?** Yes
### Details of bug
This was discovered while trying to answer https://github.com/NGEET/fates/discussions/1562. During discussion with the author, it was noted that the current version sets the no data type for the `fates_fire_data_method`:
https://github.com/ESCOMP/CTSM/blob/e1f563b8345400d33421263f05b237f13e6b0e3d/src/biogeochem/FATESFireFactoryMod.F90#L89-L90
The version the author is using (`ctsm5.3.012`), is inclusive of the `successful_ignitions` option:
https://github.com/ESCOMP/CTSM/blob/ab466d6f9789ca3df2c72bda46cf7afed2d04102/src/biogeochem/FATESFireFactoryMod.F90#L65-L66
I believe the code should be updated to reinstate `successful_ignitions` as an option.
Note that this namelist option does not have a test, in part, due to #1266.
### Important details of your setup / configuration so we can reproduce the bug
`fates_spitfire_mode = 3`
### Important output or errors that show the problem
This hasn't been tested yet to determine what the output response is.
Contributor guide
Assessment
This issue has not been assessed yet.