ESCOMP / ESCOMP/CTSM

Put use_init_interp in $nl_flags as either .true. or .false. so can be correctly handled in namelist_defaults_ctsm.xml

Open
#3,832 0 comments 0 reactions 1 assignee Claimed by @ekluzek View on GitHub
b4b enhancement usability
Dominant language
Fortran
Stars
352
Forks
361
Avg merge
6d 6h
Merged PRs (30d)
8

Description

Logical attributes in namelist_defaults files need to have been converted to the $nl_flags dictionary so that they will be either .true. or .false. so that the comparison works correctly. Logical values are allowed to be different case, and shortened with or without the "." in front and after. As such they should be stored in $nl_flags in the two options, based on the logical value.

use_init_interp isn't handled this way, and as such if the user enters "T" or "TRUE" the namelist_defaults matches might not work correctly.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.