After ifx NaN work: Bring in my scripts
Open
b4b
blocker
test: python
- Dominant language
- Fortran
- Stars
- 352
- Forks
- 361
- Avg merge
- 6d 6h
- Merged PRs (30d)
- 8
Description
I wrote some Python scripts to make the changes to netCDF files for ctsm5.4.022 and ctsm5.4.023, but I didn't actually include my scripts because it wasn't clear they would be needed. Turns out they probably will be, for #3803, so I should get on that.
I'm not going to open a PR yet, because this will probably need to happen in a few PRs, and I'm going to do some brute-force git history cleanup. I'll thus list my remaining work here:
- [ ] Don't touch finidat files (see #3825)
- [ ] Use `ncap2 -s 'defdim("$DIMNAME",$DIMLENGTH)'` to restore dimensions that get removed during scripts! This was the cause of #3825, as @olyson discovered.
- [ ] Add docstrings and type hinting
- [ ] Increase test coverage?
Contributor guide
Assessment
This issue has not been assessed yet.