CAM LndTuningMode testmods should only shorten ROF_NCPL for short tests
- Dominant language
- Fortran
- Stars
- 352
- Forks
- 361
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 7
Description
### Brief summary of bug
ROF_NCPL, for at least the clm60cam7LndTuningMode (and likely for the others as well), is higher frequency which is needed for the 9-step cases, but longer cases don't need that done. So tests should only do this for the short 9 step cases and NOT for cases longer than 3 hours.
### General bug information
**CTSM version you are using:** ctsm5.4.022-6-gf2b311cc9
**Does this bug cause significantly incorrect results in the model's science?** No
**Configurations affected:** tests using one of the LndTuningMode testmods
### Details of bug
One implementation would be to have the shell_commands check the value of STOP_OPTION and only change ROF_NCPL if it's set to nsteps. This would probably be fine, since it's only a few tests currently the only nstep tests are either for 9 or 1 step (numbers of tests are 49 and 11 respectively).
### Important details of your setup / configuration so we can reproduce the bug
I saw this in a SMS.ne30pg3_t232.I2000Clm60BgcCrop.derecho_intel.clm-clm60cam7LndTuningMode test.
### Important output or errors that show the problem
``` shell
git grep NCPL | more
FatesColdCamLndTuningMode/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
FatesColdSatPhenCamLndTuningMode/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
clm45cam4LndTuningModeZDustSoilErod/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
clm50cam5LndTuningModeZDustSoilErod/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
clm50cam6LndTuningMode/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
clm50cam7LndTuningMode/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
clm60cam6LndTuningMode/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
clm60cam7LndTuningMode/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
for_testing_fastsetup_bypassrun/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
waccmx_offline/shell_commands:./xmlchange USE_ESMF_LIB=TRUE,ATM_NCPL=288,CALENDAR=GREGORIAN,ROF_NCPL='$ATM_NCPL',LND_TUNING_MODE="clm5_0_cam6.0"
waccmx_offline/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
```
And this applies to all of these tests (from git grep LndTuning testlist_clm.xml | grep -v Ln9):
``` xml
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
testlist_clm.xml:
```
The for_testing_fastsetup_bypassrun and waccmx_offline tests are both short on purpose, so it's OK for it to be short.
Contributor guide
Assessment
This issue has not been assessed yet.