ESCOMP / ESCOMP/CTSM

Clarify when use_c13/use_c14 and carbon isotopes timeseries can be used

Open
#3,641 2 comments 0 reactions 0 assignees View on GitHub
b4b code health usability
Dominant language
Fortran
Stars
352
Forks
361
Avg merge
2d 21h
Merged PRs (30d)
7

Description

build-namelist doesn't restrict when use_c13/use_c14 can be turned on. It does restrict use_c13_timeseries and use_c14_bombspike to be only on when use_c13 and/or use_c14 are on respectively.

The code doesn't allow use_c13 or use_c14 to be on when FATES is on.

However, both soilbiogeochem and biogeochem use use_c13/use_c14, so can use_c13/use_c14 be allowed when use_cn is NOT on?

In controlMod you can always set them -- but they only get printed out when use_cn is true.

CNVegetationFacade has some use_c13/use_c14 uses inside if statements of either use_cn or use_fates_bgc...

``` fortran
if(use_cn.or.use_fates_bgc)then

```

dynSubgridDriverMod calls DynamicAreaConservation from CNVegetationFacade which has use_c13/c14 if statements from inside a use_cn if statement. CNDriver has uses in CNDriverNoLeaching, CNDriverSummerizesStates, CNDriverSummerizesFluxes. And these are called from clm_driver, with some in use_cn if statements and some as above...

``` fortran
if (use_cn .or. use_fates_bgc) then
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.