ESCOMP / ESCOMP/CTSM

astemf (and other) parameters should have nonzero missing value

Open
#3,619 0 comments 0 reactions 0 assignees View on GitHub
b4b code health enhancement
Dominant language
Fortran
Stars
352
Forks
361
Avg merge
6d 6h
Merged PRs (30d)
8

Description

As part of my crop reparameterization work, I noticed that the `astemf` parameter is set to the missing value for some crops. This would have caused errors (at least in debug and/or nag) in some comparisons, so I was confused until I realized that the missing value (or fill value) for that parameter is zero. This should be changed to avoid confusion when inspecting the paramfile—the missing value should be something truly meaningless, and non-crops should be set to that.

This may be true for other crop allocation parameters as well.

Adding "next" to discuss milestone.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.