ESCOMP / ESCOMP/CTSM

mksurfdata_esmf should check that pfts 1-16 end up with hbot htop sai > 0 when lai > 0

Open
#3,526 1 comment 0 reactions 1 assignee Claimed by @slevis-lmwg View on GitHub
b4b code health test: mksurfdata
Dominant language
Fortran
Stars
352
Forks
361
Avg merge
6d 6h
Merged PRs (30d)
8

Description

In #3501 the test `ERP_D_Ld3_PS.f09_g17.I2000Clm50Sp.derecho_intel.clm-prescribed` that reads LAI via streams, uncovered a problem originating in the LAI raw data that was intended for ctsm5.4:
- The new LAI raw data (unlike prior LAI raw data) stops with pft 14 and does not include pft 15
- As a result, fsurdat files end up with lai, sai, htop, hbot = 0 for pfts 15 and 16
- Test-suite tests not reading LAI via streams do not fail because the model sends pfts 15 and 16 through BareGroundFluxes
- The "prescribed" test fails because lai > 0 sends pfts 15 and 16 through CanopyFluxes where sai, htop, hbot = 0 result in z0 = 0, which enters a log function and triggers a segmentation fault

This problem could have been caught in mksurfdata_esmf by checking that grid cells with lai > 0 end up with hbot htop sai > 0, else there's a problem.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.