Change nclumps test to npes in decompInit_lnd and clarify the use of processors...
Open
b4b
code health
- Dominant language
- Fortran
- Stars
- 352
- Forks
- 361
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 7
Description
The error check test for npes to nclumps is incorect in ctsm5.3.078, and should be fixed or possibly removed. If left in we should figure out a way to unit test it.
It also uses the term "processor" when it really means "MPI task". This should possibly be clarified in decompInit. The relation of nclumps and tasks and threads should possibly be clarified as well.
@mvdebolskiy pointed this out here:
https://github.com/ESCOMP/CTSM/pull/3517/files#r2401196709
Contributor guide
Assessment
This issue has not been assessed yet.