Don't allow reset_snow and reset_snow_glc on a branch
- Dominant language
- Fortran
- Stars
- 352
- Forks
- 361
- Avg merge
- 6d 6h
- Merged PRs (30d)
- 8
Description
We should disallow reset_snow and reset_snow_glc. Mostly because they only apply within the initial reset_snow_timesteps of the start of a simulation. So they don't do anything after that. And actually, if the branch is starting from within reset_snow_timesteps -- they will need to match the simulation the branch is restarting from.
> @billsacks it looks like we should do the same thing with reset_snow and reset_snow_glc so that they can't be true on a branch. Does that sound right to you?
_Originally posted by @ekluzek in [#3257](https://github.com/ESCOMP/CTSM/issues/3257#issuecomment-2997603781)_
Also see:
> I don't think this is as necessary for `reset_snow`: my recollection and understanding from the logic is that it already won't be active on a branch run. The difference from `reseed_dead_plants` is that `reset_snow` happens in the run loop for some initial number of time steps (if `get_nstep() <= reset_snow_timesteps`) (it doesn't work to do this resetting in initialization). Since (I think) nstep keeps counting in a branch run rather than being reset to 0, `reset_snow` won't have any effect in a branch run.
>
> That said, if you think it would be better to raise an error in this case, then that's fine with me.
_Originally posted by @billsacks in [#3257](https://github.com/ESCOMP/CTSM/issues/3257#issuecomment-2997672319)_
Contributor guide
Assessment
This issue has not been assessed yet.