ESCOMP / ESCOMP/CTSM

PLUMBER2 dtlimit needs to bet set correctly: Add test

Open
#2,779 2 comments 0 reactions 2 assignees Claimed by @slevis-lmwg View on GitHub
bug science testing
Dominant language
Fortran
Stars
352
Forks
361
Avg merge
2d 21h
Merged PRs (30d)
7

Description

### Brief summary of bug

Running a plumber2 spinup doesn't work with current user_mods

### General bug information

**CTSM version you are using:** [output of `git describe`]
branch_tags/ctsm5.3.n04_ctsm5.2.028

**Does this bug cause significantly incorrect results in the model's science?** [Yes / No]
No, but it makes spinning up PLUMBER2 cases difficult

**Configurations affected:** [Fill this in if known.]
PLUMBER2 spinup

### Details of bug
Updates to cdeps now have site name included in datm.streams.xml
` `

This means that [shell commands](https://github.com/ESCOMP/CTSM/blob/master/cime_config/usermods_dirs/PLUMBER2/defaults/shell_commands) and defaults for [user_nl_datm_streams](https://github.com/ESCOMP/CTSM/blob/master/cime_config/usermods_dirs/PLUMBER2/defaults/user_nl_datm_streams) need to include the site name on the stream info.

Alternatively, this stream_info could be removed from cdeps?

### Important details of your setup / configuration so we can reproduce the bug

Case showing the issue is here
/glade/derecho/scratch/wwieder/PLUMBER2_tests/ZM-Mon_spin_SP_test_5.3.n04

the following were added to user_nl_datm_stream
```
PLUMBER2.ZM-Mon:taxmode=cycle
PLUMBER2.ZM-Mon:dtlimit=30
```

Previously the were set as below, but not modified in datm.stream.xml:

```
CLM_USRDAT.PLUMBER2:taxmode=cycle
CLM_USRDAT.PLUMBER2:dtlimit=30
```

Maybe this can be fixed in #2406?

Definition of Done:
- [x] Update CDEPS to version that includes the fix from @TeaganKing
- [x] Bring in #2406 (on b4b-dev)
- [x] Bring b4b-dev to master
- [ ] Add a System test for at least one PLUMBER site

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.